| 1 | package control |
| 2 | |
| 3 | import ( |
| 4 | "encoding/json" |
| 5 | "os" |
| 6 | "path/filepath" |
| 7 | "strings" |
| 8 | "testing" |
| 9 | |
| 10 | "reasonix/internal/agent" |
| 11 | "reasonix/internal/event" |
| 12 | "reasonix/internal/evidence" |
| 13 | ) |
| 14 | |
| 15 | func writeLegacyGoalArchive(t *testing.T, root, taskID, goal string) string { |
| 16 | t.Helper() |
| 17 | taskRoot := filepath.Join(root, ".reasonix", "autoresearch", taskID) |
| 18 | if err := os.MkdirAll(filepath.Join(taskRoot, "state"), 0o755); err != nil { |
| 19 | t.Fatal(err) |
| 20 | } |
| 21 | if err := os.MkdirAll(filepath.Join(taskRoot, "logs"), 0o755); err != nil { |
| 22 | t.Fatal(err) |
| 23 | } |
| 24 | for name, body := range map[string]string{ |
| 25 | "state/task_spec.json": `{"task_id":"` + taskID + `","goal":"` + goal + `","allowed_operations":{"write":true},"success_criteria":[]}`, |
| 26 | "state/progress.json": `{"status":"running","updated_at":"2026-06-30T10:00:00Z"}`, |
| 27 | "state/directions_tried.json": "[]\n", |
| 28 | "state/findings.jsonl": "", |
| 29 | "state/iteration_log.jsonl": "", |
| 30 | "logs/heartbeat.jsonl": "", |
| 31 | } { |
| 32 | if err := os.WriteFile(filepath.Join(taskRoot, name), []byte(body), 0o644); err != nil { |
| 33 | t.Fatal(err) |
| 34 | } |
| 35 | } |
| 36 | return taskRoot |
| 37 | } |
| 38 | |
| 39 | func TestUnknownPersistedBudgetClassFallsBackToGoalClassification(t *testing.T) { |
| 40 | dir := t.TempDir() |
| 41 | path := filepath.Join(dir, "session.jsonl") |
| 42 | raw, err := json.Marshal(goalState{Goal: "fix the crash in settings", Status: GoalStatusRunning, BudgetClass: "future-budget-class", TurnsLimit: 99}) |
| 43 | if err != nil { |
| 44 | t.Fatal(err) |
| 45 | } |
| 46 | if err := os.WriteFile(goalStatePath(path), raw, 0o644); err != nil { |
| 47 | t.Fatal(err) |
| 48 | } |
| 49 | g := &goalMachine{} |
| 50 | g.setStatePath(goalStatePath(path)) |
| 51 | _, _, migrated, _ := g.restoreFromState(path) |
| 52 | if migrated || !g.disarmed || g.budgetClass != budgetClassWrite || g.turnsLimit != unlimitedGoalTurns { |
| 53 | t.Fatalf("unknown budget restore = migrated:%v class:%q turns:%d", migrated, g.budgetClass, g.turnsLimit) |
| 54 | } |
| 55 | } |
| 56 | |
| 57 | func TestGoalSidecarWriterFencesLegacyAutoResearchForEveryBudget(t *testing.T) { |
| 58 | tests := []struct { |
| 59 | name string |
| 60 | goal string |
| 61 | class string |
| 62 | }{ |
| 63 | {name: "simple", goal: "summarize the current status", class: budgetClassSimple}, |
| 64 | {name: "write", goal: "fix the settings crash", class: budgetClassWrite}, |
| 65 | {name: "research", goal: "investigate the latency regression thoroughly", class: budgetClassResearch}, |
| 66 | } |
| 67 | for _, tt := range tests { |
| 68 | t.Run(tt.name, func(t *testing.T) { |
| 69 | dir := t.TempDir() |
| 70 | sessionPath := filepath.Join(dir, "session.jsonl") |
| 71 | g := &goalMachine{statePath: goalStatePath(sessionPath)} |
| 72 | path, raw, ok := g.set(tt.goal, tt.class) |
| 73 | if !ok { |
| 74 | t.Fatal("set did not produce sidecar data") |
| 75 | } |
| 76 | var state goalState |
| 77 | if err := json.Unmarshal(raw, &state); err != nil { |
| 78 | t.Fatal(err) |
| 79 | } |
| 80 | if state.ResearchMode != GoalResearchOff || state.AutoResearchTaskID != "" { |
| 81 | t.Fatalf("legacy reader fence missing: %+v", state) |
| 82 | } |
| 83 | if state.BudgetClass != tt.class || state.TurnsLimit != unlimitedGoalTurns { |
| 84 | t.Fatalf("compatibility state = %+v, want class %s with unlimited turns", state, tt.class) |
| 85 | } |
| 86 | // Frozen previous readers treated any non-Off mode or retained task id |
| 87 | // as an AutoResearch activation signal. |
| 88 | var legacyReader struct { |
| 89 | ResearchMode GoalResearchMode `json:"researchMode"` |
| 90 | AutoResearchTaskID string `json:"autoResearchTaskID"` |
| 91 | } |
| 92 | if err := json.Unmarshal(raw, &legacyReader); err != nil { |
| 93 | t.Fatal(err) |
| 94 | } |
| 95 | if legacyReader.ResearchMode != GoalResearchOff || strings.TrimSpace(legacyReader.AutoResearchTaskID) != "" { |
| 96 | t.Fatal("frozen previous reader would reactivate AutoResearch") |
| 97 | } |
| 98 | if err := g.writeStateErr(path, raw); err != nil { |
| 99 | t.Fatal(err) |
| 100 | } |
| 101 | reloaded := &goalMachine{} |
| 102 | reloaded.restoreFromState(sessionPath) |
| 103 | if reloaded.budgetClass != tt.class || reloaded.turnsLimit != unlimitedGoalTurns { |
| 104 | t.Fatalf("reloaded compatibility state = %q/%d, want %q/unlimited", reloaded.budgetClass, reloaded.turnsLimit, tt.class) |
| 105 | } |
| 106 | }) |
| 107 | } |
| 108 | } |
| 109 | |
| 110 | func TestEmptyGoalSidecarStillFencesLegacyAutoResearch(t *testing.T) { |
| 111 | g := &goalMachine{statePath: filepath.Join(t.TempDir(), "goal.json")} |
| 112 | _, raw, ok := g.set("", "") |
| 113 | if !ok { |
| 114 | t.Fatal("empty Goal did not produce stopped sidecar state") |
| 115 | } |
| 116 | var state goalState |
| 117 | if err := json.Unmarshal(raw, &state); err != nil { |
| 118 | t.Fatal(err) |
| 119 | } |
| 120 | if state.ResearchMode != GoalResearchOff || state.AutoResearchTaskID != "" || state.BudgetClass != "" { |
| 121 | t.Fatalf("empty Goal downgrade fence = %+v", state) |
| 122 | } |
| 123 | } |
| 124 | |
| 125 | func TestGoalSetIdempotencyUsesEffectiveBudgetClass(t *testing.T) { |
| 126 | g := &goalMachine{statePath: filepath.Join(t.TempDir(), "goal.json")} |
| 127 | if _, _, ok := g.set("same goal", budgetClassSimple); !ok { |
| 128 | t.Fatal("initial set did not persist") |
| 129 | } |
| 130 | if _, _, ok := g.set("same goal", budgetClassSimple); ok { |
| 131 | t.Fatal("same Goal and budget class was not idempotent") |
| 132 | } |
| 133 | if _, _, ok := g.set("same goal", budgetClassResearch); !ok { |
| 134 | t.Fatal("budget class change was incorrectly treated as idempotent") |
| 135 | } |
| 136 | if g.budgetClass != budgetClassResearch || g.turnsLimit != unlimitedGoalTurns { |
| 137 | t.Fatalf("budget upgrade = class:%q turns:%d", g.budgetClass, g.turnsLimit) |
| 138 | } |
| 139 | } |
| 140 | |
| 141 | func TestLegacySidecarArchiveFailureBlocksWithRetryableTaskID(t *testing.T) { |
| 142 | root := t.TempDir() |
| 143 | if resolved, err := filepath.EvalSymlinks(root); err == nil { |
| 144 | root = resolved |
| 145 | } |
| 146 | sessionPath := filepath.Join(root, "sessions", "s.jsonl") |
| 147 | if err := os.MkdirAll(filepath.Dir(sessionPath), 0o755); err != nil { |
| 148 | t.Fatal(err) |
| 149 | } |
| 150 | const ( |
| 151 | taskID = "retry-legacy-archive" |
| 152 | scopeID = "legacy-goal-scope" |
| 153 | ) |
| 154 | wantTodo := evidence.TodoItem{Content: "preserve legacy verification", Status: "in_progress"} |
| 155 | wantCheckpoint := evidence.DeliveryCheckpoint{ScopeID: scopeID, CriteriaEstablished: true, WorkObserved: true} |
| 156 | legacy := goalState{ |
| 157 | Status: GoalStatusRunning, ResearchMode: GoalResearchOn, AutoResearchTaskID: taskID, |
| 158 | ScopeID: scopeID, DeliveryCheckpoint: wantCheckpoint, Todos: []evidence.TodoItem{wantTodo}, |
| 159 | BudgetClass: budgetClassResearch, TurnsUsed: 3, TurnsLimit: 40, TokensUsed: 1234, |
| 160 | NoProgressTurns: 2, NoProgressLimit: 0, BudgetExtensions: 1, |
| 161 | LastContinuationReason: "continue verification", |
| 162 | } |
| 163 | raw, err := json.Marshal(legacy) |
| 164 | if err != nil { |
| 165 | t.Fatal(err) |
| 166 | } |
| 167 | if err := os.WriteFile(goalStatePath(sessionPath), raw, 0o644); err != nil { |
| 168 | t.Fatal(err) |
| 169 | } |
| 170 | |
| 171 | sess := agent.NewSession("sys") |
| 172 | exec := agent.New(nil, nil, sess, agent.Options{}, event.Discard) |
| 173 | c := newOwnedTestController(t, Options{WorkspaceRoot: root, SessionDir: root, Executor: exec}) |
| 174 | c.Resume(sess, sessionPath) |
| 175 | defer c.Close() |
| 176 | if got := c.GoalStatus(); got != GoalStatusBlocked { |
| 177 | t.Fatalf("failed legacy restore status = %q, want blocked", got) |
| 178 | } |
| 179 | failedRaw, err := os.ReadFile(goalStatePath(sessionPath)) |
| 180 | if err != nil { |
| 181 | t.Fatal(err) |
| 182 | } |
| 183 | var failed goalState |
| 184 | if err := json.Unmarshal(failedRaw, &failed); err != nil { |
| 185 | t.Fatal(err) |
| 186 | } |
| 187 | if failed.Status != GoalStatusBlocked || failed.ResearchMode != GoalResearchOn || failed.AutoResearchTaskID != taskID || failed.StopCause != stopCauseLegacyArchive || failed.Block == "" { |
| 188 | t.Fatalf("failed restore state = %+v, want retryable blocked legacy migration", failed) |
| 189 | } |
| 190 | if failed.ScopeID != scopeID || failed.DeliveryCheckpoint != wantCheckpoint || len(failed.Todos) != 0 { |
| 191 | t.Fatalf("failed restore lost goal state: %+v", failed) |
| 192 | } |
| 193 | if failed.BudgetClass != budgetClassResearch || failed.TurnsUsed != 3 || failed.TurnsLimit != 40 || failed.TokensUsed != 1234 || failed.NoProgressTurns != 2 || failed.BudgetExtensions != 1 { |
| 194 | t.Fatalf("failed restore lost runtime state: %+v", failed) |
| 195 | } |
| 196 | if got := exec.CanonicalTodoState(); len(got) != 0 { |
| 197 | t.Fatalf("failed restore activated legacy todos: %+v", got) |
| 198 | } |
| 199 | if runtime := c.GoalRuntime(); runtime.TurnsUsed != 3 || runtime.TurnsLimit != 0 || runtime.TokensUsed != 1234 || runtime.NoProgressTurns != 2 { |
| 200 | t.Fatalf("failed restore lost in-memory runtime state: %+v", runtime) |
| 201 | } |
| 202 | taskRoot := writeLegacyGoalArchive(t, root, taskID, "recover after archive repair") |
| 203 | archiveBefore, err := os.ReadFile(filepath.Join(taskRoot, "state", "task_spec.json")) |
| 204 | if err != nil { |
| 205 | t.Fatal(err) |
| 206 | } |
| 207 | |
| 208 | if !c.ResumeGoal() { |
| 209 | t.Fatal("repaired archive did not resume through the in-memory legacy token") |
| 210 | } |
| 211 | if got := c.Goal(); got != "recover after archive repair" { |
| 212 | t.Fatalf("retried Goal() = %q", got) |
| 213 | } |
| 214 | if got := c.GoalStatus(); got != GoalStatusRunning { |
| 215 | t.Fatalf("retried status = %q, want running", got) |
| 216 | } |
| 217 | runtime := c.GoalRuntime() |
| 218 | if runtime.TurnsUsed != 3 || runtime.TurnsLimit != 0 || runtime.TokensUsed != 1234 || runtime.NoProgressTurns != 2 || runtime.BudgetExtensions != 0 { |
| 219 | t.Fatalf("retried runtime = %+v, want preserved legacy consumption", runtime) |
| 220 | } |
| 221 | if got := exec.CanonicalTodoState(); len(got) != 0 { |
| 222 | t.Fatalf("retried legacy goal activated archived todos: %+v", got) |
| 223 | } |
| 224 | if got := c.goals.deliveryState(); got != wantCheckpoint { |
| 225 | t.Fatalf("retried delivery checkpoint = %+v, want %+v", got, wantCheckpoint) |
| 226 | } |
| 227 | retriedRaw, err := os.ReadFile(goalStatePath(sessionPath)) |
| 228 | if err != nil { |
| 229 | t.Fatal(err) |
| 230 | } |
| 231 | var retried goalState |
| 232 | if err := json.Unmarshal(retriedRaw, &retried); err != nil { |
| 233 | t.Fatal(err) |
| 234 | } |
| 235 | if retried.AutoResearchTaskID != "" || retried.StopCause != "" || retried.Block != "" { |
| 236 | t.Fatalf("successful retry retained migration-only fields: %+v", retried) |
| 237 | } |
| 238 | archiveAfter, err := os.ReadFile(filepath.Join(taskRoot, "state", "task_spec.json")) |
| 239 | if err != nil { |
| 240 | t.Fatal(err) |
| 241 | } |
| 242 | if string(archiveAfter) != string(archiveBefore) { |
| 243 | t.Fatal("legacy archive changed during retry") |
| 244 | } |
| 245 | } |
| 246 | |
| 247 | func TestLegacySidecarPendingTaskRetriesAfterRestart(t *testing.T) { |
| 248 | root := t.TempDir() |
| 249 | sessionPath := filepath.Join(root, "sessions", "restart.jsonl") |
| 250 | if err := os.MkdirAll(filepath.Dir(sessionPath), 0o755); err != nil { |
| 251 | t.Fatal(err) |
| 252 | } |
| 253 | const taskID = "restartable-legacy" |
| 254 | raw, err := json.Marshal(goalState{ |
| 255 | Status: GoalStatusRunning, ResearchMode: GoalResearchOn, |
| 256 | AutoResearchTaskID: taskID, BudgetClass: budgetClassResearch, TurnsUsed: 4, TurnsLimit: 40, |
| 257 | }) |
| 258 | if err != nil { |
| 259 | t.Fatal(err) |
| 260 | } |
| 261 | if err := os.WriteFile(goalStatePath(sessionPath), raw, 0o644); err != nil { |
| 262 | t.Fatal(err) |
| 263 | } |
| 264 | |
| 265 | firstSession := agent.NewSession("sys") |
| 266 | first := newOwnedTestController(t, Options{WorkspaceRoot: root, SessionDir: root, Executor: agent.New(nil, nil, firstSession, agent.Options{}, event.Discard)}) |
| 267 | first.Resume(firstSession, sessionPath) |
| 268 | if first.GoalStatus() != GoalStatusBlocked { |
| 269 | t.Fatalf("first restore status = %q, want blocked", first.GoalStatus()) |
| 270 | } |
| 271 | first.Close() |
| 272 | |
| 273 | writeLegacyGoalArchive(t, root, taskID, "recover after process restart") |
| 274 | secondSession := agent.NewSession("sys") |
| 275 | second := newOwnedTestController(t, Options{WorkspaceRoot: root, SessionDir: root, Executor: agent.New(nil, nil, secondSession, agent.Options{}, event.Discard)}) |
| 276 | defer second.Close() |
| 277 | second.Resume(secondSession, sessionPath) |
| 278 | if second.GoalStatus() != GoalStatusStopped || second.Goal() != "recover after process restart" { |
| 279 | t.Fatalf("restart migration = goal:%q status:%q", second.Goal(), second.GoalStatus()) |
| 280 | } |
| 281 | persisted, err := os.ReadFile(goalStatePath(sessionPath)) |
| 282 | if err != nil { |
| 283 | t.Fatal(err) |
| 284 | } |
| 285 | var state goalState |
| 286 | if err := json.Unmarshal(persisted, &state); err != nil { |
| 287 | t.Fatal(err) |
| 288 | } |
| 289 | if state.AutoResearchTaskID != "" || state.ResearchMode != GoalResearchOff || state.BudgetClass != budgetClassResearch { |
| 290 | t.Fatalf("restart migration left compatibility fields: %+v", state) |
| 291 | } |
| 292 | } |
| 293 | |
| 294 | func TestLegacySidecarInvalidArchivesRemainRetryableAndReadOnly(t *testing.T) { |
| 295 | tests := []struct { |
| 296 | name string |
| 297 | file string |
| 298 | mutate func(taskID string) string |
| 299 | }{ |
| 300 | {name: "corrupt json", file: "state/progress.json", mutate: func(string) string { return "{not-json" }}, |
| 301 | {name: "invalid schema", file: "state/task_spec.json", mutate: func(string) string { |
| 302 | return `{"task_id":"different-task","goal":"schema mismatch","allowed_operations":{"write":true},"success_criteria":[]}` |
| 303 | }}, |
| 304 | {name: "empty goal", file: "state/task_spec.json", mutate: func(taskID string) string { |
| 305 | return `{"task_id":"` + taskID + `","goal":"","allowed_operations":{"write":true},"success_criteria":[]}` |
| 306 | }}, |
| 307 | } |
| 308 | for _, tt := range tests { |
| 309 | t.Run(tt.name, func(t *testing.T) { |
| 310 | root := t.TempDir() |
| 311 | taskID := "invalid-" + strings.ReplaceAll(tt.name, " ", "-") |
| 312 | taskRoot := writeLegacyGoalArchive(t, root, taskID, "recover only from a valid archive") |
| 313 | target := filepath.Join(taskRoot, tt.file) |
| 314 | if err := os.WriteFile(target, []byte(tt.mutate(taskID)), 0o644); err != nil { |
| 315 | t.Fatal(err) |
| 316 | } |
| 317 | archiveBefore, err := os.ReadFile(target) |
| 318 | if err != nil { |
| 319 | t.Fatal(err) |
| 320 | } |
| 321 | sessionPath := filepath.Join(root, "sessions", "s.jsonl") |
| 322 | if err := os.MkdirAll(filepath.Dir(sessionPath), 0o755); err != nil { |
| 323 | t.Fatal(err) |
| 324 | } |
| 325 | raw, err := json.Marshal(goalState{ |
| 326 | Status: GoalStatusRunning, ResearchMode: GoalResearchOn, |
| 327 | AutoResearchTaskID: taskID, BudgetClass: budgetClassResearch, TurnsLimit: 40, |
| 328 | }) |
| 329 | if err != nil { |
| 330 | t.Fatal(err) |
| 331 | } |
| 332 | if err := os.WriteFile(goalStatePath(sessionPath), raw, 0o644); err != nil { |
| 333 | t.Fatal(err) |
| 334 | } |
| 335 | |
| 336 | sess := agent.NewSession("sys") |
| 337 | exec := agent.New(nil, nil, sess, agent.Options{}, event.Discard) |
| 338 | c := newOwnedTestController(t, Options{WorkspaceRoot: root, SessionDir: root, Executor: exec}) |
| 339 | c.Resume(sess, sessionPath) |
| 340 | defer c.Close() |
| 341 | if c.GoalStatus() != GoalStatusBlocked || c.ResumeGoal() { |
| 342 | t.Fatalf("invalid archive status=%q resumed unexpectedly", c.GoalStatus()) |
| 343 | } |
| 344 | persistedRaw, err := os.ReadFile(goalStatePath(sessionPath)) |
| 345 | if err != nil { |
| 346 | t.Fatal(err) |
| 347 | } |
| 348 | var persisted goalState |
| 349 | if err := json.Unmarshal(persistedRaw, &persisted); err != nil { |
| 350 | t.Fatal(err) |
| 351 | } |
| 352 | if persisted.AutoResearchTaskID != taskID || persisted.ResearchMode != GoalResearchOn || persisted.StopCause != stopCauseLegacyArchive { |
| 353 | t.Fatalf("retry state = %+v", persisted) |
| 354 | } |
| 355 | archiveAfter, err := os.ReadFile(target) |
| 356 | if err != nil { |
| 357 | t.Fatal(err) |
| 358 | } |
| 359 | if string(archiveAfter) != string(archiveBefore) { |
| 360 | t.Fatal("invalid legacy archive changed during failed restore") |
| 361 | } |
| 362 | }) |
| 363 | } |
| 364 | } |
| 365 | |
| 366 | func TestLegacySidecarArchiveCanRetryInSameController(t *testing.T) { |
| 367 | root := t.TempDir() |
| 368 | sessionPath := filepath.Join(root, "sessions", "s.jsonl") |
| 369 | if err := os.MkdirAll(filepath.Dir(sessionPath), 0o755); err != nil { |
| 370 | t.Fatal(err) |
| 371 | } |
| 372 | const taskID = "same-controller-retry" |
| 373 | legacy := goalState{ |
| 374 | Status: GoalStatusRunning, AutoResearchTaskID: taskID, ResearchMode: GoalResearchOn, |
| 375 | TurnsUsed: 5, TurnsLimit: 20, |
| 376 | } |
| 377 | raw, err := json.Marshal(legacy) |
| 378 | if err != nil { |
| 379 | t.Fatal(err) |
| 380 | } |
| 381 | if err := os.WriteFile(goalStatePath(sessionPath), raw, 0o644); err != nil { |
| 382 | t.Fatal(err) |
| 383 | } |
| 384 | |
| 385 | sess := agent.NewSession("sys") |
| 386 | exec := agent.New(nil, nil, sess, agent.Options{}, event.Discard) |
| 387 | c := newOwnedTestController(t, Options{WorkspaceRoot: root, SessionDir: root, Executor: exec}) |
| 388 | c.Resume(sess, sessionPath) |
| 389 | defer c.Close() |
| 390 | if c.GoalStatus() != GoalStatusBlocked || c.ResumeGoal() { |
| 391 | t.Fatal("missing archive did not remain blocked") |
| 392 | } |
| 393 | |
| 394 | writeLegacyGoalArchive(t, root, taskID, "recover objective in the same controller") |
| 395 | if !c.ResumeGoal() { |
| 396 | t.Fatal("repaired sidecar archive did not resume in the same controller") |
| 397 | } |
| 398 | if got := c.Goal(); got != "recover objective in the same controller" { |
| 399 | t.Fatalf("Goal() = %q, want recovered archive objective", got) |
| 400 | } |
| 401 | if runtime := c.GoalRuntime(); runtime.TurnsUsed != 5 || runtime.TurnsLimit != 0 { |
| 402 | t.Fatalf("runtime = %+v, want preserved use without a turn quota", runtime) |
| 403 | } |
| 404 | persisted, err := os.ReadFile(goalStatePath(sessionPath)) |
| 405 | if err != nil { |
| 406 | t.Fatal(err) |
| 407 | } |
| 408 | if strings.Contains(string(persisted), "autoResearchTaskID") { |
| 409 | t.Fatalf("successful retry retained legacy task id: %s", persisted) |
| 410 | } |
| 411 | } |
| 412 | |
| 413 | func TestLegacyArchiveMigrationWriteFailureRemainsBlockedAndRetryable(t *testing.T) { |
| 414 | root := t.TempDir() |
| 415 | const taskID = "write-retry" |
| 416 | writeLegacyGoalArchive(t, root, taskID, "recover after sidecar write repair") |
| 417 | |
| 418 | sess := agent.NewSession("sys") |
| 419 | exec := agent.New(nil, nil, sess, agent.Options{}, event.Discard) |
| 420 | c := newOwnedTestController(t, Options{WorkspaceRoot: root, SessionDir: root, Executor: exec}) |
| 421 | defer c.Close() |
| 422 | |
| 423 | blockedParent := filepath.Join(root, "not-a-directory") |
| 424 | if err := os.WriteFile(blockedParent, []byte("block mkdir"), 0o644); err != nil { |
| 425 | t.Fatal(err) |
| 426 | } |
| 427 | c.goals.setStatePath(filepath.Join(blockedParent, "goal.json")) |
| 428 | rawGoal := "resume .reasonix/autoresearch/" + taskID + "/" |
| 429 | _, _, _ = c.goals.setLegacyArchiveBlocked(rawGoal, budgetClassResearch, "retry migration") |
| 430 | _, epoch, ok := c.goals.legacyArchiveBlockedState() |
| 431 | if !ok { |
| 432 | t.Fatal("legacy archive block state unavailable") |
| 433 | } |
| 434 | c.replaceLegacyRestore(legacyGoalRestore{taskID: taskID, epoch: epoch, explicit: true}) |
| 435 | |
| 436 | if c.ResumeGoal() { |
| 437 | t.Fatal("migration reported success after its sidecar write failed") |
| 438 | } |
| 439 | goal, retryEpoch, blocked := c.goals.legacyArchiveBlockedState() |
| 440 | legacy, hasLegacy := c.legacyRestoreSnapshot() |
| 441 | if !blocked || !hasLegacy || legacy.taskID != taskID || retryEpoch != legacy.epoch || goal != "recover after sidecar write repair" { |
| 442 | t.Fatalf("failed write lost retry state: goal=%q legacy=%+v blocked=%v", goal, legacy, blocked) |
| 443 | } |
| 444 | if c.GoalStatus() != GoalStatusBlocked { |
| 445 | t.Fatalf("status = %q, want fail-closed blocked", c.GoalStatus()) |
| 446 | } |
| 447 | |
| 448 | statePath := filepath.Join(root, "sessions", "goal.json") |
| 449 | c.goals.setStatePath(statePath) |
| 450 | if !c.ResumeGoal() { |
| 451 | t.Fatal("migration did not retry after sidecar persistence was repaired") |
| 452 | } |
| 453 | raw, err := os.ReadFile(statePath) |
| 454 | if err != nil { |
| 455 | t.Fatal(err) |
| 456 | } |
| 457 | var persisted goalState |
| 458 | if err := json.Unmarshal(raw, &persisted); err != nil { |
| 459 | t.Fatal(err) |
| 460 | } |
| 461 | if persisted.Status != GoalStatusRunning || persisted.AutoResearchTaskID != "" || persisted.ResearchMode != GoalResearchOff { |
| 462 | t.Fatalf("retried migration state = %+v", persisted) |
| 463 | } |
| 464 | } |
| 465 | |
| 466 | func TestStaleLegacyArchiveRetryCannotReplaceNewGoal(t *testing.T) { |
| 467 | var g goalMachine |
| 468 | g.setLegacyArchiveBlocked("resume .reasonix/autoresearch/old/", budgetClassResearch, "missing") |
| 469 | _, epoch, ok := g.legacyArchiveBlockedState() |
| 470 | if !ok { |
| 471 | t.Fatal("legacy archive block state unavailable") |
| 472 | } |
| 473 | g.set("new goal", budgetClassWrite) |
| 474 | if _, resumed := g.resumeLegacyArchive(epoch, "stale archive goal"); resumed { |
| 475 | t.Fatal("stale archive retry replaced a newer Goal") |
| 476 | } |
| 477 | if got := g.goalText(); got != "new goal" { |
| 478 | t.Fatalf("Goal() = %q, want concurrent replacement", got) |
| 479 | } |
| 480 | } |
| 481 | |
| 482 | func TestStaleInitialLegacyFailureCannotBlockNewGoal(t *testing.T) { |
| 483 | var g goalMachine |
| 484 | g.set("legacy goal", budgetClassResearch) |
| 485 | epoch := g.continuationToken() |
| 486 | g.set("new goal", budgetClassWrite) |
| 487 | |
| 488 | if _, blocked := g.blockLegacyRestore(epoch, "archive disappeared"); blocked { |
| 489 | t.Fatal("stale archive failure blocked a newer Goal") |
| 490 | } |
| 491 | if got := g.goalText(); got != "new goal" || g.statusForDisplay() != GoalStatusRunning { |
| 492 | t.Fatalf("Goal = %q status=%q, want newer running Goal", got, g.statusForDisplay()) |
| 493 | } |
| 494 | } |
| 495 | |
| 496 | func TestStaleLegacyMigrationCannotRewriteNewGoalSidecar(t *testing.T) { |
| 497 | statePath := filepath.Join(t.TempDir(), "goal.json") |
| 498 | g := &goalMachine{statePath: statePath} |
| 499 | g.set("legacy goal", budgetClassResearch) |
| 500 | legacyEpoch := g.continuationToken() |
| 501 | path, data, ok := g.set("new goal", budgetClassWrite) |
| 502 | if !ok { |
| 503 | t.Fatal("new Goal did not build sidecar state") |
| 504 | } |
| 505 | if err := g.writeStateErr(path, data); err != nil { |
| 506 | t.Fatal(err) |
| 507 | } |
| 508 | if applied, err := g.writeStateAtEpoch(legacyEpoch); err != nil || applied { |
| 509 | t.Fatalf("stale migration write = applied:%v err:%v", applied, err) |
| 510 | } |
| 511 | raw, err := os.ReadFile(statePath) |
| 512 | if err != nil { |
| 513 | t.Fatal(err) |
| 514 | } |
| 515 | var state goalState |
| 516 | if err := json.Unmarshal(raw, &state); err != nil { |
| 517 | t.Fatal(err) |
| 518 | } |
| 519 | if state.Goal != "new goal" { |
| 520 | t.Fatalf("sidecar Goal = %q, want new goal", state.Goal) |
| 521 | } |
| 522 | } |
| 523 | |
| 524 | func TestLegacySidecarWithGoalMigratesWithoutArchive(t *testing.T) { |
| 525 | root := t.TempDir() |
| 526 | sessionPath := filepath.Join(root, "sessions", "s.jsonl") |
| 527 | if err := os.MkdirAll(filepath.Dir(sessionPath), 0o755); err != nil { |
| 528 | t.Fatal(err) |
| 529 | } |
| 530 | legacy := goalState{ |
| 531 | Goal: "preserve the original goal", Status: GoalStatusRunning, |
| 532 | AutoResearchTaskID: "missing-archive", ResearchMode: GoalResearchOn, |
| 533 | TurnsUsed: 2, TurnsLimit: 40, |
| 534 | } |
| 535 | raw, err := json.Marshal(legacy) |
| 536 | if err != nil { |
| 537 | t.Fatal(err) |
| 538 | } |
| 539 | if err := os.WriteFile(goalStatePath(sessionPath), raw, 0o644); err != nil { |
| 540 | t.Fatal(err) |
| 541 | } |
| 542 | |
| 543 | sess := agent.NewSession("sys") |
| 544 | exec := agent.New(nil, nil, sess, agent.Options{}, event.Discard) |
| 545 | c := newOwnedTestController(t, Options{WorkspaceRoot: root, SessionDir: root, Executor: exec}) |
| 546 | c.Resume(sess, sessionPath) |
| 547 | defer c.Close() |
| 548 | if got := c.Goal(); got != legacy.Goal { |
| 549 | t.Fatalf("Goal() = %q, want %q", got, legacy.Goal) |
| 550 | } |
| 551 | if got := c.GoalStatus(); got != GoalStatusStopped { |
| 552 | t.Fatalf("status = %q, want running", got) |
| 553 | } |
| 554 | if runtime := c.GoalRuntime(); runtime.TurnsUsed != 2 || runtime.TurnsLimit != 0 { |
| 555 | t.Fatalf("runtime = %+v, want preserved research budget", runtime) |
| 556 | } |
| 557 | persistedRaw, err := os.ReadFile(goalStatePath(sessionPath)) |
| 558 | if err != nil { |
| 559 | t.Fatal(err) |
| 560 | } |
| 561 | var persisted goalState |
| 562 | if err := json.Unmarshal(persistedRaw, &persisted); err != nil { |
| 563 | t.Fatal(err) |
| 564 | } |
| 565 | if persisted.AutoResearchTaskID != "missing-archive" || persisted.ResearchMode != GoalResearchOn { |
| 566 | t.Fatalf("migrated sidecar = %+v, want Goal-only research state", persisted) |
| 567 | } |
| 568 | } |
| 569 | |
| 570 | func TestExplicitLegacyGoalRetryNeverRunsArchivePathAsGoal(t *testing.T) { |
| 571 | root := t.TempDir() |
| 572 | sessionPath := filepath.Join(root, "sessions", "s.jsonl") |
| 573 | sess := agent.NewSession("sys") |
| 574 | exec := agent.New(nil, nil, sess, agent.Options{}, event.Discard) |
| 575 | c := newOwnedTestController(t, Options{WorkspaceRoot: root, SessionDir: root, Executor: exec}) |
| 576 | c.Resume(sess, sessionPath) |
| 577 | defer c.Close() |
| 578 | |
| 579 | const taskID = "repair-explicit-archive" |
| 580 | rawGoal := "resume .reasonix/autoresearch/" + taskID + "/" |
| 581 | c.SetGoal(rawGoal) |
| 582 | if got := c.GoalStatus(); got != GoalStatusBlocked { |
| 583 | t.Fatalf("initial status = %q, want blocked", got) |
| 584 | } |
| 585 | persistedRaw, err := os.ReadFile(goalStatePath(sessionPath)) |
| 586 | if err != nil { |
| 587 | t.Fatal(err) |
| 588 | } |
| 589 | var blocked goalState |
| 590 | if err := json.Unmarshal(persistedRaw, &blocked); err != nil { |
| 591 | t.Fatal(err) |
| 592 | } |
| 593 | if blocked.Status != GoalStatusBlocked || blocked.StopCause != stopCauseLegacyArchive || blocked.AutoResearchTaskID != taskID || blocked.ResearchMode != GoalResearchOn { |
| 594 | t.Fatalf("blocked sidecar = %+v", blocked) |
| 595 | } |
| 596 | if c.ResumeGoal() { |
| 597 | t.Fatal("resume succeeded while archive was still missing") |
| 598 | } |
| 599 | if got := c.Goal(); got != rawGoal || c.GoalStatus() != GoalStatusBlocked { |
| 600 | t.Fatalf("failed retry changed Goal: goal=%q status=%q", got, c.GoalStatus()) |
| 601 | } |
| 602 | |
| 603 | writeLegacyGoalArchive(t, root, taskID, "recover the original objective") |
| 604 | if !c.ResumeGoal() { |
| 605 | t.Fatal("resume did not recover the repaired archive") |
| 606 | } |
| 607 | if got := c.Goal(); got != "recover the original objective" { |
| 608 | t.Fatalf("Goal() = %q, want archive objective", got) |
| 609 | } |
| 610 | if c.GoalStatus() != GoalStatusRunning || c.GoalRuntime().TurnsLimit != 0 { |
| 611 | t.Fatalf("recovered runtime = status:%q %+v", c.GoalStatus(), c.GoalRuntime()) |
| 612 | } |
| 613 | } |
| 614 | |
| 615 | func TestMalformedLegacyArchivePathCannotResumeAsGoalText(t *testing.T) { |
| 616 | c := newOwnedTestController(t, Options{WorkspaceRoot: t.TempDir()}) |
| 617 | defer c.Close() |
| 618 | |
| 619 | c.SetGoal("resume .reasonix/autoresearch/../escape") |
| 620 | if c.GoalStatus() != GoalStatusBlocked { |
| 621 | t.Fatalf("status = %q, want blocked", c.GoalStatus()) |
| 622 | } |
| 623 | if c.ResumeGoal() { |
| 624 | t.Fatal("malformed archive path resumed as an ordinary Goal") |
| 625 | } |
| 626 | if c.GoalStatus() != GoalStatusBlocked { |
| 627 | t.Fatalf("status after resume = %q, want blocked", c.GoalStatus()) |
| 628 | } |
| 629 | } |
| 630 | |
| 631 | func TestMalformedExplicitLegacyGoalStaysBlockedAfterRestart(t *testing.T) { |
| 632 | root := t.TempDir() |
| 633 | sessionPath := filepath.Join(root, "sessions", "s.jsonl") |
| 634 | rawGoal := "resume .reasonix/autoresearch/bad-task/../../escape" |
| 635 | |
| 636 | exec1 := agent.New(nil, nil, agent.NewSession("sys"), agent.Options{}, event.Discard) |
| 637 | c1 := newOwnedTestController(t, Options{WorkspaceRoot: root, SessionDir: root, Executor: exec1}) |
| 638 | c1.Resume(agent.NewSession("sys"), sessionPath) |
| 639 | c1.SetGoal(rawGoal) |
| 640 | if got := c1.GoalStatus(); got != GoalStatusBlocked { |
| 641 | t.Fatalf("initial status = %q, want blocked", got) |
| 642 | } |
| 643 | c1.Close() |
| 644 | |
| 645 | c2 := newOwnedTestController(t, Options{WorkspaceRoot: root, SessionDir: root}) |
| 646 | c2.Resume(agent.NewSession("sys"), sessionPath) |
| 647 | defer c2.Close() |
| 648 | if got := c2.GoalStatus(); got != GoalStatusBlocked { |
| 649 | t.Fatalf("restart status = %q, want blocked", got) |
| 650 | } |
| 651 | if c2.ResumeGoal() { |
| 652 | t.Fatal("malformed explicit archive resumed after restart") |
| 653 | } |
| 654 | if got := c2.Goal(); got != rawGoal { |
| 655 | t.Fatalf("restart retry changed Goal = %q, want %q", got, rawGoal) |
| 656 | } |
| 657 | } |
| 658 | |
| 659 | func TestMissingLegacyGoalCommandDoesNotStartProviderTurn(t *testing.T) { |
| 660 | runner := &gatedTurnRunner{started: make(chan struct{}), release: make(chan struct{})} |
| 661 | c := newOwnedTestController(t, Options{WorkspaceRoot: t.TempDir(), Runner: runner}) |
| 662 | t.Cleanup(c.Close) |
| 663 | |
| 664 | if !c.applyGoalCommand("/goal resume .reasonix/autoresearch/missing-task/", "") { |
| 665 | t.Fatal("legacy Goal command was not parsed") |
| 666 | } |
| 667 | if c.Running() { |
| 668 | t.Fatal("missing legacy archive started a provider turn") |
| 669 | } |
| 670 | if got := c.GoalStatus(); got != GoalStatusBlocked { |
| 671 | t.Fatalf("GoalStatus() = %q, want blocked", got) |
| 672 | } |
| 673 | } |
| 674 | |
| 675 | func TestUnreadableExplicitLegacyArchiveBlocks(t *testing.T) { |
| 676 | root := t.TempDir() |
| 677 | const taskID = "unreadable-explicit-archive" |
| 678 | taskRoot := writeLegacyGoalArchive(t, root, taskID, "never run an unreadable archive") |
| 679 | specPath := filepath.Join(taskRoot, "state", "task_spec.json") |
| 680 | if err := os.Remove(specPath); err != nil { |
| 681 | t.Fatal(err) |
| 682 | } |
| 683 | if err := os.Mkdir(specPath, 0o755); err != nil { |
| 684 | t.Fatal(err) |
| 685 | } |
| 686 | c := newOwnedTestController(t, Options{WorkspaceRoot: root}) |
| 687 | t.Cleanup(c.Close) |
| 688 | |
| 689 | c.SetGoal("resume .reasonix/autoresearch/" + taskID + "/") |
| 690 | if got := c.GoalStatus(); got != GoalStatusBlocked { |
| 691 | t.Fatalf("GoalStatus() = %q, want blocked", got) |
| 692 | } |
| 693 | if got := c.Goal(); got != "resume .reasonix/autoresearch/"+taskID+"/" { |
| 694 | t.Fatalf("Goal() = %q, archive goal must not be trusted", got) |
| 695 | } |
| 696 | } |
| 697 |